[sslh] [PATCH 0/5] small sslh cleanup series
Yves Rutschle
yves at naryves.com
Tue Aug 6 14:04:01 CEST 2013
On Tue, Aug 06, 2013 at 07:34:55AM -0400, Jason Cooper wrote:
> On a development note, I prefer to send patches to a mailinglist because
> pull requests are for code that has been reviewed and approved. This
> stuff hasn't been reviewed or approved yet.
Ah, so I can easily request you to amend a patch then?
(If yes: in version.h patch (5/5), I'd rather have version.h
included once from common.h instead of twice from
sslh-main.c and common.c: VERSION is fundamentally a global
constant, hence common, hence can be defined everywhere).
Y.
More information about the sslh
mailing list