[sslh] [PATCH 0/5] small sslh cleanup series
Jason Cooper
sslh at lakedaemon.net
Tue Aug 6 13:34:55 CEST 2013
On Tue, Aug 06, 2013 at 08:54:33AM +0100, Matt Smith wrote:
> On 2013-08-05 18:33, Jason Cooper wrote:
> >Yves,
> >
> >Attached is a small series of cleanups since you migrated to git.
> >Thanks for
> >doing that by the way!
> >
>
> Considering you're using git, wouldn't this have been better to just
> submit a pull request via github for your patches rather than
> sending them all to this mailing list? That's what pull requests are
> for! It'll be far easier for Yves to merge them in.
You deleted the critical portion of my email that provided that option:
> > If you're interested in just pulling the branch, it's here:
> >
> > git://git.infradead.org/users/jcooper/sslh.git cleanup
> >
That's the essence of a pull-request when you take away all the
bubblewrap, foam-cornered gui-ness of github. :-P
The beauty of it is that you don't have to lock yourself into the
"github way", you can pull from any publicly hosted git tree.
On a development note, I prefer to send patches to a mailinglist because
pull requests are for code that has been reviewed and approved. This
stuff hasn't been reviewed or approved yet.
thx,
Jason.
More information about the sslh
mailing list