[sslh] [PATCH 0/5] small sslh cleanup series

[Jason Cooper]

On Tue, Aug 06, 2013 at 02:04:01PM +0200, Yves Rutschle wrote:
> On Tue, Aug 06, 2013 at 07:34:55AM -0400, Jason Cooper wrote:
> > On a development note, I prefer to send patches to a mailinglist because
> > pull requests are for code that has been reviewed and approved.  This
> > stuff hasn't been reviewed or approved yet.
> 
> Ah, so I can easily request you to amend a patch then?

Sure, that's the point. ;-)

> (If yes: in version.h patch (5/5), I'd rather have version.h
> included once from common.h instead of twice from
> sslh-main.c and common.c: VERSION is fundamentally a global
> constant, hence common, hence can be defined everywhere).

Ok, I'll admit I did see that, but I defaulted to the kernel coding
style of directly including the needed includes.  For large projects, it
makes maintenance easier, but it doesn't hurt anything either way.

v2 on it's way.

thx,

Jason.