[sslh] sslh-1.22c - failing tests

[Björn Ketelaars]

I'm experiencing a couple of failing regression tests with sslh-1.22c on
OpenBSD current, which seem to be related to incorrect test
conditions/assumptions. I can easily patch these tests locally but I
would like to check them with someone who knows better:

Index: test.cfg
--- test.cfg.orig
+++ test.cfg
@@ -18,7 +18,7 @@ listen:
 (
     { host: "localhost"; port: "8080"; keepalive: true; },
     { host: "localhost"; port: "8081"; keepalive: true; },
-    { host: "ip4-localhost"; is_udp: true; port: "8086"; }
+    { host: "127.0.0.1"; is_udp: true; port: "8086"; }
 );

OpenBSD does not understand ip4-localhost, so I guess 127.0.0.1 is ok.

@@ -32,7 +32,7 @@ protocols:
      { name: "xmpp";  host: "localhost"; port: "9009"; },
      { name: "adb";  host: "localhost"; port: "9010"; },
      { name: "syslog"; host: "localhost"; port: "9013"; },
-     { name: "regex"; host: "ip4-localhost"; is_udp: true; port: "9020";
+     { name: "ssh"; host: "127.0.0.1"; is_udp: true; port: "9020";
          udp_timeout: 30;
          regex_patterns: [ "^foo" ];
      },

Next to changing ip4-localhost to 127.0.0.1 I needed to do something
hairy: change regex to ssh. This actually feels wrong; if the test case
is actually ok, then there could be an issue with forwarding an UDP
packet on OpenBSD.

@@ -44,7 +44,7 @@ protocols:
             { pattern: "fooo"; result: "regex"; },
             { pattern: "bar"; result: "ssh"; },
             { pattern: "barr"; result: "regex"; },
-            { pattern: "barrrr"; result: "regex"; }
+            { pattern: "barrr"; result: "regex"; }
         );
      },
      { name: "tls"; host: "localhost"; port: "9021"; alpn_protocols: [ "alpn1", "alpn2" ]; sni_hostnames: [ "sni1" ]; },

Removing one "r" ensures that the test passes...


Comments are much appreciated!