[sslh] [PATCH 02/10] Let defer_write accumulate data
Yves Rutschle
yves at naryves.com
Tue Sep 24 14:20:21 CEST 2013
On Tue, Sep 24, 2013 at 10:09:32AM +0200, ondra+sslh at mistotebe.net wrote:
> Hmm, I thought you make sure in sslh-select that you drain the entire
> buffer before trying to read next time.
Yes that's correct.
> Also, defer_write was not able add more data to the buffer before the
> patch, causing a memory leak instead.
Yes, that's also correct. defer_write just get some data to
write "later", then sslh stops reading until that data has
been written and the deferred buffer freed.
Ok, so maybe I misunderstood the indent of your patch: I
thought it was precisely to be able to pile up additional
data in the deferred buffer. If not, then I don't get the
point of your patch? (I haven't gone through the following
patches in depth yet).
Y.
More information about the sslh
mailing list