[sslh] sslh-1.10-rc1: FreeBSD support, multiple targets
Yves Rutschle
yves at naryves.com
Tue Nov 1 17:06:54 CET 2011
Hi Guillaume,
On Tue, Nov 01, 2011 at 12:35:42PM +0100, Guillaume Delacour wrote:
> * Change the options in the test file (t) due to changes in 1.9 (long
> options).
I'm currently heavily extending the test suite, so that's
actually already been done. I've also added test coverage, I
started on some robustness tests as well.
> * In my attempt to build sslh Debian package with hardening options [1],
> i encounter a minor build issue with -Wformat, -Wformat-security and
> -Werror=format-security.
Good idea, thanks.
> --- a/common.c
> +++ b/common.c
> @@ -699,7 +699,7 @@
> break;
>
> default:
> - fprintf(stderr, USAGE_STRING);
> + fprintf(stderr, "%s", USAGE_STRING);
> exit(2);
> }
> }
Arguably gcc shouldn't complain on that one: USAGE_STRING is
a const char under the program's control, so we *know* it
can't come from outside.
I'll apply anyhoo.
Cheers,
Y.
More information about the sslh
mailing list